Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove np.int and np.float #3295

Merged
merged 1 commit into from
May 9, 2021
Merged

remove np.int and np.float #3295

merged 1 commit into from
May 9, 2021

Conversation

lilyminium
Copy link
Member

Fixes #3113

Changes made in this Pull Request:

  • np.int is deprecated and will not work for numpy 1.20+
  • Changed np.int in RDKit tests to np.int32 and np.int64

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@lilyminium lilyminium requested a review from IAlibay May 8, 2021 20:06
@codecov
Copy link

codecov bot commented May 8, 2021 •
edited
Loading

Codecov Report

Merging #3295 (b7204bf) into develop (a9eafab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3295   +/-   ##
========================================
  Coverage    93.56%   93.56%           
========================================
  Files          172      172           
  Lines        22785    22785           
  Branches      3191     3191           
========================================
  Hits         21319    21319           
  Misses        1416     1416           
  Partials        50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9eafab...b7204bf. Read the comment docs.

orbeckst
orbeckst approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I assume that was the only np.int?

@lilyminium
Copy link
Member Author

Outside of documentation, yeah :)

@lilyminium lilyminium changed the title remove np.int remove np.int and np.float May 9, 2021
@lilyminium lilyminium merged commit d734a89 into MDAnalysis:develop May 9, 2021
@lilyminium lilyminium deleted the no-npint branch May 9, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

@IAlibay IAlibay Awaiting requested review from IAlibay

Assignees
No one assigned
Labels
maintainability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

np.int, np.float etc now deprecated
3 participants
@lilyminium @orbeckst @IAlibay